Possible incorrect argument used in test of inc_beta_ddb
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 839
- Forks
- 220
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 14
Description
I think an incorrect argument is being passed to the function calls inc_beta_ddb_test:
Shouldn't the fourth argument be digamma(small_b) instead of digamma(small_a) (and similarly to the other tests)?
Obviously this does not mean anything for the function itself, but it makes it difficult to check independently what the expected value should have been.
Apologies if I misunderstood something :)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in test/unit/math/prim/fun/inc_beta_ddb_test.cpp at lines 18–21 and review the inc_beta_ddb_test calls, including the analogous cases. Confirm whether the fourth argument should use digamma(small_b) rather than digamma(small_a), then update the incorrect test arguments so the expected values can be checked independently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100