generalize Eigen NumTraits specializations for decay types
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 839
- Forks
- 220
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 14
Description
Description
Our specialization of Eigen's NumTraits class hardcodes stan::math::var. If instead we template on a type T then require a var on the decayed type of T, this will generalize to const and reference qualified variables.
At that point, the base_type tests can be extended to things like Eigen::Matrix<const var, -1, -1>.
Current Version:
v3.1.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Eigen NumTraits specialization that currently names stan::math::var and the existing base_type tests. Read how the specialization determines its base type, then review the related Eigen and autodiff type behavior. Done means the specialization handles decayed const and reference-qualified variables and the tests cover cases such as Eigen::Matrix<const var, -1, -1>.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100