stan-dev / stan-dev/cmdstanpy

Save data as attribute on fit objects

Open
#863 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
Python
Stars
198
Forks
81
PR merge metrics
No merged PRs in 30d

Description

This was requested by @OriolAbril for better integration with Arviz. I think the main issue will be when we're creating a fit object from files, the data will no longer be around (unless we start saving it, which would fit with the ethos of #851 but could lead to unnecessary duplication of possibly-quite-large files)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the fit-object construction paths, especially creation from files, and trace where input data is currently available. Clarify whether data should be retained on the fit object or only referenced, then define behavior for file-based fits and large inputs; done means the Arviz integration can access the intended data without unnecessary duplication.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.