stan-dev / stan-dev/cmdstan

interpret return codes for users

Open
#991 4 comments 0 reactions 1 assignee View on GitHub

@mitzimorris is already working on this.

Since Mar 10, 2021.

user experience
Dominant language
C++
Stars
238
Forks
106
Avg merge
2h 29m
Merged PRs (30d)
6

Description

Summary:

Improve error hadling by mapping stan::services::error_codes to messages that make sense to end-user.

Description:

Module stan::services adopted a small set of POSIX error codes following Unix conventions -
https://github.com/stan-dev/stan/blob/develop/src/stan/services/error_codes.hpp

Use of these codes is not consistent across the services, nor does command.hpp do a very good job of interpreting them for the user. Modify command.hpp to provide better feedback for common user mistakes, such as missing data inputs, etc.

All exceptions thrown from command.hpp are caught by main.cpp which uniformly returns error code 70 (stan::services::error_codes::SOFTWARE).

The stan::services error codes shouldn't be reported to end user in CmdStan. Instead, we should replace error code 70 et all with more generally accepted codes

Current Version:

v2.26.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.