stan-dev / stan-dev/cmdstan

Add Jenkins tests for makefiles

Open
#877 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
238
Forks
106
Avg merge
2h 29m
Merged PRs (30d)
6

Description

Description:

We should add Jenkins tests that would test typical makefile issues we have seen over time that we have to manually check every time we change the makefiles:

  • example bernoulli model compiles
  • main.o and precompiled headers are rebuilt if a change is done in math or stan submodules
  • model recompiles if a change is done to the cmdstan src files (without touching the stan model)
  • model compilation works correctly if removing .hpp file (without and with touching the stan model)
  • clean-all works as expected
  • example bernoulli model compiles with STAN_THREADS on

Those should be runnable by runCmdstanTests.py and tested on all three OSes.

Current Version:

v2.23.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the makefiles and the runCmdstanTests.py entry point. Review how existing tests compile the example bernoulli model and run them on all three OSes. Done means coverage for rebuild behavior, removed headers, clean-all, and STAN_THREADS compilation without manual checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
build-system, ci-cd, cli, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.