stan-dev / stan-dev/bayesplot

ppc_loo_pit_overlay(): NA values generated near ends after convolution in boundary correction

Open
#241 0 comments 0 reactions 2 assignees View on GitHub

@ecoronado92 is already working on this.

Since Oct 16, 2020.

bug
Dominant language
R
Stars
442
Forks
93
Avg merge
3h 11m
Merged PRs (30d)
1

Description

Currently boundary correction generates NAs for values near ends of vector after convolution . Important to note that # of NAs "varies" so na.omit() won't work and will cause size inconsistencies. Current fix, use last non-null value at head and tail of vector as padding.

See line 627 in R/ppc-loo.R

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.