should we drop the vertical line in mcmc_areas() and mcmc_areas_ridges()?
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 442
- Forks
- 93
- Avg merge
- 3h 11m
- Merged PRs (30d)
- 1
Description
I'm starting to think that maybe we shouldn't be hardcoding the vertical line at zero at all. Users don't have the option to remove and it would be super easy for them to add a vertical afterwards if they want it. We could consider suggesting users add + vline_0() (or + geom_vline(xintercept=0) directly) after making the plot if they want the vertical line.
I'm not saying we should definitely change this, just thinking out loud. Of course if someone wants the plot without the line they do already have the option of getting the data from mcmc_*_data() and making it themselves.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting mcmc_areas() and mcmc_areas_ridges(), then compare their plotting behavior with mcmc_*_data(). Review how vline_0() and geom_vline(xintercept=0) are used. Done requires a decided, documented behavior for the default vertical line and corresponding tests or examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100