stadiamaps / stadiamaps/ferrostar

Android: TripProgressView doesn't update ETA correctly

Open
#753 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
419
Forks
81
Avg merge
6d 1h
Merged PRs (30d)
7

Description

The ETA shown in the progress screen doesn't get updated consistently/regularly in mainline ferrostar. I found that the `progress` reference doesn't change (the passed object is mutated instead) and because of that the UI doesn't seem to get recomposed, meaning `fromDate` is never updated.

https://github.com/stadiamaps/ferrostar/blob/b78e4aa66f9c169eca4b70742488c17e3c390335/android/composeui/src/main/java/com/stadiamaps/ferrostar/composeui/views/components/TripProgressView.kt#L72

I implemented a change in Cardinal Maps to fix this: https://gitlab.e.foundation/e/os/cardinal/-/merge_requests/50

There may be better ways, but this is the first thing that occurred to me.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.