stadiamaps / stadiamaps/ferrostar

Don't throw an exception from startNavigation

Open
#72 1 comment 0 reactions 0 assignees View on GitHub
android good first issue iOS
Dominant language
Kotlin
Stars
419
Forks
81
Avg merge
6d 1h
Merged PRs (30d)
7

Description

This is inside the `startNavigation` function. The current experience was for convenience and ease of a "clean" implementation but it can be confusing to users.

While most users won't ever hit it (it's hard to get a route without a location), throwing isn't great.

Possible solutions:
* Accept a third parameter: `UserLocation` of some sort
* Wait for an update from the location provider and capture that we are "pending" navigation

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.