stacks-network / stacks-network/stacks-core

[Test] Update RPC tests to run in both epoch2 and Nakamoto chainstate

Open
#4,192 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

argon3.0
Dominant language
Rust
Stars
3.1k
Forks
762
Avg merge
4d 6h
Merged PRs (30d)
76

Description

We almost missed a show-stopping regression in https://github.com/stacks-network/stacks-core/pull/4163 because the unit tests for the RPC endpoints only test chainstate with epoch2 data. Changes in pox-4 are not tested by these tests. As part of building out the network state machines for Nakamoto, these tests will need to be updated to test against Nakamoto state (e.g. so we can verify that Nakamoto block downloading works, etc.).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the unit tests for the RPC endpoints and review the regression context in pull request 4163. Compare their epoch2 chainstate coverage with the Nakamoto and pox-4 state paths, then run the RPC tests. Done means the tests exercise both epoch2 and Nakamoto chainstate, including coverage relevant to Nakamoto block downloading.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, distributed-systems, testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.