stacklok / stacklok/toolhive

mcpservers CRD: shortNames collide with the CRD's own names, leaving NamesAccepted=False

Open Beginner friendly
#6,685 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs-triage
Dominant language
Go
Stars
2.2k
Forks
300
Avg merge
1d 15h
Merged PRs (30d)
184

Description

The 0.49.0 mcpservers CRD ships shortNames: [mcpserver, mcpservers] (likely from the #4592 consistency pass). Both collide with the CRD's own singular/plural, and the API server rejects a shortName equal to the CRD's own names — so the CRD installs with NamesAccepted=False / ShortNamesConflict ("mcpserver" is already in use, "mcpservers" is already in use). The CRD still establishes and serves, but anything waiting on NamesAccepted (helm --wait, terraform, argo health) hangs on it; my operator-crds Helm upgrade failed on exactly that.

0.0.106 shipped no shortNames for this CRD and worked fine. Still present on main (deploy/charts/operator-crds/templates/toolhive.stacklok.dev_mcpservers.yaml).

I worked around it with a post-renderer that drops the shortNames block; a fix would be to just remove both entries (or pick non-colliding ones).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect deploy/charts/operator-crds/templates/toolhive.stacklok.dev_mcpservers.yaml and compare its shortNames with the 0.0.106 CRD, which had none. Render or install the chart and verify the CRD no longer reports NamesAccepted=False / ShortNamesConflict, including with helm --wait, terraform, or Argo health checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
86/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.