Delete the dead pkg/vmcp/server/adapter package
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 2.2k
- Forks
- 300
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 184
Description
Surfaced in jhrozek's review of #6180.
Problem
pkg/vmcp/server/adapter/ (capability_adapter.go, handler_factory.go) has no non-test callers — NewCapabilityAdapter/NewDefaultHandlerFactory are dead code. Its CreateResourceHandler (handler_factory.go:164) still drops result.Meta while its sibling CreateToolHandler preserves it — it's now the only surviving copy of the resource-_meta drop that #6180 removed from the live paths, which invites re-divergence if anyone ever wires it back in.
Work
Delete the package and its tests. Verify with a repo-wide reference check first (the review found no non-test callers; confirm nothing in cmd/ or the operator imports it).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pkg/vmcp/server/adapter/capability_adapter.go and handler_factory.go, including their tests. Run a repo-wide reference check and confirm that cmd/ and the operator do not import the package. Done means the package and its tests are deleted, with no remaining references and the repository checks passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 84/100