stacklok / stacklok/toolhive

Flip StorageVersionMigrator default to on before v1alpha1 removal

Open
#5,598 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

go kubernetes operator
Dominant language
Go
Stars
2.2k
Forks
300
Avg merge
1d 15h
Merged PRs (30d)
184

Description

Follow-up to #4969.

The StorageVersionMigrator controller, opt-in CRD labels + CI guard, chart feature flag, and docs all shipped (PRs #5362, #5391, #5418, #5451). The feature is currently opt-in / default-off:

  • cmd/thv-operator/app/app.goisStorageVersionMigratorEnabled() defaults to false (admins set TOOLHIVE_ENABLE_STORAGE_VERSION_MIGRATOR=true)
  • deploy/charts/operator/values.yamloperator.features.storageVersionMigrator: false

Remaining work (the originally-planned PR-C flip)

Before the release that drops v1alpha1 from the ToolHive CRDs' spec.versions, flip the default to on so every cluster's status.storedVersions is cleaned during the deprecation window:

  • Flip operator-code default to true
  • Set operator.features.storageVersionMigrator: true in values.yaml (regenerate chart README)
  • Verify upgrade-guide docs reflect default-on behaviour and the opt-out path for admins running kube-storage-version-migrator externally

This is gated on release timing, not implementation.

🤖 Generated with Claude Code

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in cmd/thv-operator/app/app.go and deploy/charts/operator/values.yaml, then locate the chart README and upgrade-guide documentation mentioned in the issue. Confirm the release timing and existing opt-out wording before updating the defaults and regenerated documentation; done means all three checklist items are consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, helm, kubernetes
Domain
devops, documentation, infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.