EmbeddingServer finalizeEmbeddingServer silently ignores errors

Summary

The finalizeEmbeddingServer method performs cleanup actions but returns void, silently discarding errors from status updates. If the status update fails, the finalizer is still removed by the caller and the object is deleted without the final status being persisted.

Severity: SHOULD FIX
Area: Controller Error Handling
Breaking: No

Location

• cmd/thv-operator/controllers/embeddingserver_controller.go:1053-1067

Problem

func (r *EmbeddingServerReconciler) finalizeEmbeddingServer(
    ctx context.Context, es *v1alpha1.EmbeddingServer) {
    // Update status
    _ = r.Status().Update(ctx, es)  // error ignored
    r.Recorder.Eventf(es, ...)
}

If the status update fails (e.g., conflict, network error), the finalizer is still removed by the caller. The object is deleted without the final status being persisted.

Impact

• Final status update may be lost silently
• No retry mechanism for failed status updates during finalization
• Observability gap: the last status of a deleted EmbeddingServer may not reflect the actual cleanup outcome
• If cleanup involves more than just status updates in the future, errors from those operations would also be silently ignored

Recommended Fix

1. Change finalizeEmbeddingServer to return an error:

   func (r *EmbeddingServerReconciler) finalizeEmbeddingServer(
       ctx context.Context, es *v1alpha1.EmbeddingServer) error {
       if err := r.Status().Update(ctx, es); err != nil {
           return fmt.Errorf("updating final status: %w", err)
       }
       r.Recorder.Eventf(es, ...)
       return nil
   }
   

2. Handle the error in the caller — if finalization fails, requeue instead of removing the finalizer:

   if err := r.finalizeEmbeddingServer(ctx, es); err != nil {
       return ctrl.Result{}, err  // requeue; finalizer stays
   }
   // Only remove finalizer after successful finalization