stacklok / stacklok/toolhive

Make vmcp workflow distinguish between different failure states

Open
#3,031 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

audit authentication enhancement vmcp
Dominant language
Go
Stars
2.2k
Forks
300
Avg merge
1d 15h
Merged PRs (30d)
184

Description

Something to maybe chat with Jeremy about for future work: the HTTP auditor distinguishes between OutcomeFailure (client errors), OutcomeError (server/infra errors), and OutcomeDenied (auth failures). Right now workflows use OutcomeFailure for everything.

Could be useful to distinguish auth failures from backend errors etc, but that'd need the workflow engine to classify errors - probably not worth it for this PR. Just flagging as a potential future enhancement.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names the vmcp workflows, workflow engine, and HTTP auditor, but no files or tests. Start by locating those entry points and how workflows currently assign OutcomeFailure; define how client, server/infra, and auth failures should be classified, then add coverage showing each state is distinguished.

Written by the indexing model from the issue text.

Assessment

Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.