stacklok / stacklok/toolhive

API does not mark group as required in the JSON Schema

Open
#1,911 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

api bug
Dominant language
Go
Stars
2.2k
Forks
300
Avg merge
1d 15h
Merged PRs (30d)
184

Description

Bug description

The API schema does not mark group as required for workloads. This results in the need to add substantial fallback value logic in the frontend to make type checkers happy. The use of fallback default groups were flagged in a pull request. See more context here: https://stacklok.slack.com/archives/C08JYS26TV3/p1758032313140179

Steps to reproduce

not applicable here

Expected behavior

group (and any other essential fields) are marked as required

Actual behavior

group and several other fields are not appropriately marked as required.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the API schema for workloads and inspect how required fields are declared, using group as the concrete example. Identify the other essential fields referenced by the issue and verify the generated JSON Schema marks them required; done means frontend fallback default groups are no longer needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.