stacklok / stacklok/toolhive-registry-server
LastAppliedFilterHash is never persisted, breaking filter change detection
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 27
- Forks
- 15
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 16
Description
After a successful sync, LastAppliedFilterHash is not written to the database — only LastSyncHash is persisted. On the next coordinator cycle, isFilterChanged computes the current filter hash and compares it against the stored value. Because the stored value is never updated, any source whose filter was changed and synced once will continue to appear as "filter changed" on every subsequent cycle, triggering unnecessary re-syncs indefinitely.
LastAppliedFilterHash should be included in the status update written on successful sync completion.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the coordinator cycle through isFilterChanged and the status update performed after successful sync completion. Confirm where LastSyncHash is persisted, then verify that LastAppliedFilterHash is persisted there too and that a later cycle no longer reports the unchanged filter as changed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 64/100