stacklok / stacklok/toolhive-core
Remove legacy registry Go types and converters
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 2
- Forks
- 4
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 46
Description
Summary
PR #105 deleted the legacy schema and validator but intentionally kept the legacy Go types (Registry, ImageMetadata, RemoteServerMetadata) and the registry/converters/ package because external consumers still depended on them. Once those consumers are off, this repo should drop them too.
Scope
registry/types/—Registry,ImageMetadata,RemoteServerMetadataregistry/converters/— the converter package and its tests
Blocked on
stacklok/toolhive— stacklok/toolhive#5279 (aligns the registry API withtoolhive-registry-server's v0.1 surface and removes theregistry/convertersimport from toolhive's API handlers)stacklok/toolhive-catalog—cmd/catalog/update_metadata.gousesregistry/convertersfor provenance verification
This issue can land once both consumers stop importing the package.
Acceptance criteria
-
registry/types/andregistry/converters/removed. - No reverse dependencies in
stacklok/toolhiveorstacklok/toolhive-catalog. -
go build ./...andgo test ./...green.
References
- Landed: stacklok/toolhive-catalog#1215, stacklok/toolhive-core#105, stacklok/toolhive#5273
- Tracking on consumer side: stacklok/toolhive#5279
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
First check stacklok/toolhive#5279 and the catalog reference to confirm both consumers no longer import registry/converters. Then inspect registry/types/ and registry/converters/, including the converter tests, and remove them once reverse dependencies are gone. Run go build ./... and go test ./...; done means both commands pass and the listed directories and imports are absent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100