stackhpc / stackhpc/ansible-role-libvirt-vm
Domain xml template doesn't include guest agent channel
Nobody has claimed this yet.
- Dominant language
- Jinja
- Stars
- 135
- Forks
- 73
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 1
Description
Suggestion: Include guest channel when appropriate?
Noticed from some testing that vm.xml.j2 differs to a virt-install --os_varient rhe7 in that the template does not include guest agent channel, where virt-install creates a domain definition which affectivly has:
<channel type='unix'>
<target type='virtio' name='org.qemu.guest_agent.0' state='connected'/>
</channel>
In addition, some virtio serial controller and channel options are not set.
Full example for virt-install command:
virt-install --name test --memory 2048 --vcpus 4 --disk size=512 --network none --accelerate --location /var/lib/libvirt/boot/rhel7.6.iso --os-variant rhel7 --nographics --extra-args \"ks=cdrom:/ks.cfg console=tty0 console=ttyS0,115200n8\"
Tested on Red Hat 7.6.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with vm.xml.j2 and compare its generated domain definition with the virt-install example in the issue. Check how the guest agent channel and virtio serial controller or channel options should be included when appropriate. Done means the template produces the requested guest channel and relevant options for the described VM configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- xml
- Domain
- infrastructure
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100