stackbuilders / stackbuilders/react-native-spotlight-tour
Add borderRadius support to RectShape via SpotlightTourProvider
- Dominant language
- TypeScript
- Stars
- 520
- Forks
- 39
- PR merge metrics
- No merged PRs in 30d
Description
Currently, the RectShape component in package/src/lib/components/tour-overlay/shapes/RectShape.component.tsx renders with a fixed border radius of 4px via the rx and ry props on the AnimatedRect. There is no way to customize the border radius from the SpotlightTourProvider, as it does not expose a borderRadius property.
Expected behavior:
- Ability to set a custom border radius for the rectangular spotlight shape via a prop in
SpotlightTourProvider. - The shape should wrap the target component and match the desired border radius instead of always defaulting to 4px.
Current behavior:
RectShapealways renders with a border radius of 4px, which may not match the target component's border radius.- No configuration option is available to adjust this value.
Suggested solution:
- Add a
borderRadiusproperty to theSpotlightTourProviderand/or allow it to be passed to theRectShapecomponent. - Propagate the value so that
rxandryon theAnimatedRectreflect the provided value.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in package/src/lib/components/tour-overlay/shapes/RectShape.component.tsx and trace how RectShape is configured from SpotlightTourProvider. Check the open pull request linked to this issue before starting. Done means the provider accepts a custom border radius, the value reaches the rectangular spotlight, and the target shape reflects it instead of always using 4px.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 20/100