stackbuilders / stackbuilders/react-native-spotlight-tour

Suggestion: Add name/key property to AttachStep instead of index

Open
#134 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
520
Forks
39
PR merge metrics
No merged PRs in 30d

Description

I'd like to suggest that instead using index to map the attach step to the steps array, it'll be more flexible to use a key/name for the attachStep, and the steps array just referencnes the key. This way, it's easy to rearrange the order of the steps just by rearranging the steps array, instead of renumbering the AttachSteps all around the application.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how AttachStep uses its index to reference the steps array, then inspect the step configuration entry points mentioned in this issue. Define how a name or key would be assigned and resolved, and verify that rearranging the steps array no longer requires renumbering AttachStep references.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
mobile
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.