stackbuilders / stackbuilders/hapistrano
Missing test that checks old releases are dropped after a deployment
Nobody has claimed this yet.
- Dominant language
- Haskell
- Stars
- 108
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
While reviewing #174, @jpvillaisaza realized (see https://github.com/stackbuilders/hapistrano/pull/174#discussion_r800725192) that I had accidentally removed the call to dropOldReleases when a successful release was deployed, so old releases weren't being deleted; despite of this, my PR did pass the CI checks. This made clear that we need to add a test to check for that, as this behavior is to be expected since by default no more than 5 releases should be preserved unless the user increases that with the keep_releases setting via config.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing pull request #174 and its discussion, then trace the deployment path around dropOldReleases. Run the existing tests to understand the setup; done means coverage confirms successful deployments remove releases beyond the default five while respecting keep_releases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- haskell
- Domain
- release, testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100