stackabletech / stackabletech/trino-operator

Operator fails "silently" to update TrinoCluster's resource

Open
#342 2 comments 0 reactions 1 assignee View on GitHub

@Maleware is already working on this.

Since May 4, 2023.

customer-request type/bug
Dominant language
Rust
Stars
63
Forks
13
Avg merge
1d 20h
Merged PRs (30d)
12

Description

Hey Stackable Team

I have noticed when updating a TrinoCluster object with changes to replicasion, the Trino operator fail at updating. It results in a bunch of error logs for the TrinoCluster object:

ErrorResponse: { 
  status: "Failure", 
  message: "StatefulSet.apps \"gbif-trino-coordinator-default\" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden",
  reason: "Invalid", 
  code: 422 }

Steps to recreate:

  1. Create a TrinoCluster object in your namespace
  2. Change the resource quotars in a roleGroup
  3. Apply the changes
  4. See the Event log for the TrinoCluster object

As this is expected behavior for the Statefulset resource and the workaround is to recreate the object in Kubernetes so I don't see it as high priority.

I was think it would be nice to have the error returned from Kubernetes when trying to update the forbidden fields on the TrinoCluster and reject the object as to not push changes that aren't applied before recreation of the statefulset.

Another option could maybe be to allow the Trino-operator to recreate the statefulsets if the fields like resource allocation is updated.

If you don't think the issue makes sense to look into, you can close it :)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.