stackabletech / stackabletech/trino-lb
Support configuring trino-lb endpoint instead of address
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 37
- Forks
- 8
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 1
Description
Came up in https://github.com/stackabletech/trino-lb/pull/100#discussion_r2753723253
Basically, change
trinoLb:
externalAddress: https://127.0.0.1:8443
to
trinoLb:
externalEndpoint: https://127.0.0.1:8443/my/subpath
However, this is a breaking change and needs some rework of trino-lb.
Think of e.g.
fn change_next_uri_to_trino_lb(next_uri: &Url, trino_lb_addr: Url) -> Url {
let mut result = trino_lb_addr;
result.set_path(next_uri.path());
result
}
This obviously needs to be changed to handle subpaths in the trino-lb endpoint
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the trinoLb externalAddress configuration and the change_next_uri_to_trino_lb function shown in the issue. Review how the endpoint is parsed and applied, then update the surrounding behavior so a configured externalEndpoint, including its subpath, is preserved when constructing the next URI; verify the resulting routing behavior with the relevant existing checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100