stackabletech / stackabletech/operator-rs

feat(stackable-operator): Add a utility for creating Java runtime arguments

Open
#839 2 comments 0 reactions 1 assignee View on GitHub

@NickLarsenNZ is already working on this.

Since Aug 16, 2024.

Dominant language
Rust
Stars
167
Forks
19
Avg merge
1d 6h
Merged PRs (30d)
9

Description

idea (non-blocker): we could have a utility type for making properties. It might make this a little easier for humans to parse.

Originally posted by @NickLarsenNZ in https://github.com/stackabletech/spark-k8s-operator/pull/451#discussion_r1719540578

Maybe we already have something available, but this helps close the comment on the linked PR so it can be merged.

I'm thinking something like:

pub struct Properties(BTreeMap);

impl Display for JreProperties {
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
        todo!("iterate over the properties in self.0 and make -Dproperty=value joined by space");
        // write!(f, "{}", self.0)
    }
}

impl DerefMut for Properties {
   ...
}

See: https://docs.oracle.com/javase/8/docs/technotes/tools/windows/java.html#BABDJJFI

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.