stackabletech / stackabletech/operator-rs

Rework Quantity parsing

Open
#617 0 comments 0 reactions 1 assignee View on GitHub

@Techassi is already working on this.

Since Jul 5, 2023.

release-note/action-required
Dominant language
Rust
Stars
167
Forks
19
Avg merge
1d 6h
Merged PRs (30d)
9

Description

Our custom Quantity parsing doesn't match K8s behavior completely. This issue tracks the improvement of our parsing. This might break tests.

Parsing spec: https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/quantity/


This issue was raised after an internal arch meeting where the code style around resource specifications was discussed.

### Acceptance criteria
- [ ] tests are added that cover the current mismatch in parsing
- [ ] the parsing is fixed and in sync with k8s parsing
- [ ] quantity format document in the documentation is updated
See

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.