stackabletech / stackabletech/operator-rs

User defined role overrides are ignored by compute_files()

Open
#339 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
167
Forks
19
Avg merge
1d 6h
Merged PRs (30d)
9

Description

Description

Given a fictional CRD with role level configuration overrides like this:

brokers:
  configOverrides:
    server.properties:
      auto.create.topics.enable: "false"
  roleGroups:
    default:
      replicas: 1

and an implementation of Configuration::compute_files() that sets auto.create.topics.enable to true,
then the user defined override is ignored and the value of the property will be true.

Note that this doesn't happen with configuration overrides at group level!

The expectation of overrides is, that whatever the user has set , wins over everything else.

A test that demonstrates the bug is here: https://github.com/stackabletech/operator-rs/pull/338

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Configuration::compute_files() and the test demonstrating the bug in pull request #338. Compare how role-level and group-level configuration overrides are handled, then verify that the user-defined role override takes precedence over the implementation's value and that the test passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
kubernetes, rust
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.