stackabletech / stackabletech/opa-operator

Add tests for user_group_distinguished_names()

Open
#640 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/internal-debt
Dominant language
Rust
Stars
21
Forks
5
Avg merge
12h 44m
Merged PRs (30d)
11

Description

In https://github.com/stackabletech/opa-operator/pull/622#top we added an Active Directory backend to the user info fetcher.

As part of this, there was fairly extensive code to convert between some weird representations which AD chose for userids and groupids.

In order to not block the release with this we decided to punt on adding unit tests (hopefully, worst case: integration tests) for this later.

We should try and get this done fairly soon after 24.11.

Issue checklist

This is a simple checklist of things to bear in mind when creating a new issue.

  • Describe the use-case, as far is possible. For instance, using the pattern "As a XXXX, I would like XXXX to be able to do XXXX" helps to identify the feature as well as the problem it is intended to address.
  • Indicate an approximate level of importance and urgency.
  • Indicate if there is a known work-around until such time as the issue has been implemented.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the implementation and conversion code added in pull request 622, especially the user_group_distinguished_names() path. Add unit tests, or integration tests if necessary, covering the Active Directory user and group ID representations; done means the conversion behavior is exercised without blocking the release.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend, testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.