stackabletech / stackabletech/issues

Mandatory structs in objects should be `#[serde(default)]` rather than `Option`al

Open
#212 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

This should both make parsing on our end a bit less annoying, and reduce the number of possible representable states a bit.

Generally, the only fields that should be Optional are enums, objects which represent legitimately optional functionality, and, atomics (strings, numbers, label selectors, etc).

This is a part of https://github.com/stackabletech/issues/issues/198.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or affected repositories are named. Start by identifying the repositories and object structs covered by this issue and inspect their serde definitions; done means mandatory structs use #[serde(default)] instead of Option where appropriate, while enums, optional functionality, and atomic fields remain optional.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend-api-design
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.