stackabletech / stackabletech/demos

Add parameter for mapbox api key to demos containing superset

Open
#204 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
3
Forks
13
Avg merge
2d 20h
Merged PRs (30d)
2

Description

We used to roll out a mapbox api key with our Superset demos, but removed it due to the terms and conditions of mapbox.

Currently demos therefore don't display maps, until the user manually replaces the api key in a secret.

We should pull out the content of this secret as a parameter, so that users can specify an api key during start of the demo.

Also document this change in all relevant demos and mention that an api key needs to be obtained and provided if maps are to be displayed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate all Superset demos and the secret currently holding the Mapbox API key. Start by tracing how demo parameters and secrets are supplied, then update the relevant demos so users can provide a key at startup and document that a Mapbox key is required for maps to display.

Written by the indexing model from the issue text.

Assessment

Domain
devops, documentation
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.