EndPointListener Does not Process AcceptAsync Correctly?
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
Looking at EndPointListener, I noticed that AcceptAsync (2 places) does not handle the return code. If AcceptAsync returns false, onAccept will not be called, but the accept operation has been completed.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate EndPointListener and inspect its two AcceptAsync call sites, starting with how each call handles the returned boolean. Reproduce or trace the false-return path and verify that a completed accept operation is handled correctly and that onAccept is invoked when appropriate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100