FragmentLength should better not be hard coded
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
FragmentLength should better not be hard coded, and in WebSocketFrame.cs ToArray() function, the 1024 should better not be hard coded as well, IMO.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in WebSocketFrame.cs, focusing on the FragmentLength references and the ToArray() function's hard-coded 1024 value. Trace how these values are used, then remove the hard-coded values without changing existing frame behavior; verify the project still builds and its existing checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100