sta / sta/websocket-sharp

AllowForwardedRequests in HttpServer support needed

Open
#637 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
6.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

This fixed my issue of my WebsocketServer not being able to be accessed remotely. The HttpServer class doesn't support it, but seems issue to fix. Perhaps make a note about it as well on the page; I see there are reason to keep local default, but most folks would want to open up the server at some point.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the HttpServer implementation and the existing AllowForwardedRequests support in WebsocketServer to understand the differing behavior. Check the relevant documentation page, then verify that HttpServer supports forwarded requests while retaining the local default and that the option is documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.