Closing websockets doesnt work
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
Both
base.Context.WebSocket.Close();
and
this.Sessions.CloseSession(this.ID);
do not close the websocket correctly. This then results in many issues, including the application refusing to shutdown, resulting in me having to use kill -9 on it to stop it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing base.Context.WebSocket.Close() and this.Sessions.CloseSession(this.ID) through the websocket shutdown path. Reproduce the failure and inspect why the connection and application do not terminate; done means both close calls release the websocket and allow the application to shut down without kill -9.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100