Can't connect without editing code
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
currently Encountering an issue where we can't get a succesful connection. We are using unity webgl and are using a recent version of Unity TSL version 1.2 once we change your authenticate in websocket.cs line 2144
sslStream.AuthenticateAsClient(
host,
conf.ClientCertificates,
conf.EnabledSslProtocols,
conf.CheckCertificateRevocation);
to sslStream.AuthenticateAsClient(host);
it seems to work perfectly. I'm wondering what the implications might be of this change as it appears you are always sending null in conf.ClientCertificates regardless, and without those it succeeds. Maybe we are misusing it somewhere?
Thanks
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with websocket.cs at line 2144 and compare the two AuthenticateAsClient overloads in the Unity WebGL and TLS 1.2 context described. Reproduce the connection failure with conf.ClientCertificates passed, then document or fix the certificate configuration so the connection succeeds without editing the library call.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, unity
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100