sta / sta/websocket-sharp

A series of reconnecting has failed

Open
#578 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
6.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

I'm testing reconnection of the websocket client. After receiving OnClose event, my program calls the following code to reconnect (not in the OnClose thread):
websocket.Close();
websocket.Connect();

After about 10 failure and retries, I got exception "A series of reconnecting has failed". The websocket-sharp code does have the logic of _maxRetryCountForConnect=10. Anyone knows why this limitation is needed at all? And what is the best practice to reconnect except create a new WebSocket object?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the websocket.Close() and websocket.Connect() entry points and the _maxRetryCountForConnect setting mentioned in the issue. Determine how repeated reconnect attempts reach the failure exception and what behavior the existing implementation defines as complete; the issue does not name a file or test to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.