sta / sta/websocket-sharp

TLS1.2 error, docs can be improved

Open
#540 2 comments 23 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
6.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

With current push to disable weak ciphers, the:

close 1015 An exception has occurred while connecting.

error is mostly everywhere. Hence, below procedure:
private enum SslProtocolsHack
{
Tls = 192,
Tls11 = 768,
Tls12 = 3072
}
var sslProtocolHack = (System.Security.Authentication.SslProtocols)(SslProtocolsHack.Tls12 | SslProtocolsHack.Tls11 | SslProtocolsHack.Tls);ws.SslConfiguration.EnabledSslProtocols = sslProtocolHack;

needs be added in default front page documentation, otherwise people might loose a full day just researching for the error code ...

or even better, make this setting the default behavior.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the default front-page documentation and the SslConfiguration.EnabledSslProtocols setting referenced in the issue. Verify how the TLS1.2 workaround should be presented and whether changing the default behavior is intended. Done means the relevant TLS1.2 connection guidance is documented, with any default-setting decision recorded.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
networking
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.