Catching all exceptions on error
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/sta/websocket-sharp/blob/master/websocket-sharp/WebSocket.cs#L1008-L1016
Out of curiosity, why catch all exceptions after emitting the OnError event? What if someone wanted to re-throw another exception up the stack? I'm having trouble a good pattern to detect a connection failure for example... How do I notify my UI that something is wrong so that a re-connect can be initiated?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at websocket-sharp/WebSocket.cs lines 1008-1016 and trace how exceptions are handled after OnError is emitted. Review the connection-failure and reconnection paths to determine the intended propagation or notification behavior. Done requires an agreed behavior, documented handling, and verification with a connection-failure scenario.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100