Sender reference on WebSocketBehavior.onMessage()
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
It would be really useful if you changed the method WebSocketBehavior.onMessage to include the reference to the sender.
private void onMessage (object sender, MessageEventArgs e)
{
OnMessage (e);
}
to
private void onMessage (object sender, MessageEventArgs e)
{
OnMessage (sender, e);
}
and ofcourse:
protected virtual void OnMessage (object sender, MessageEventArgs e) {}
What I use for now:
Context.WebSocket
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating WebSocketBehavior.onMessage and the protected OnMessage overload shown in the issue, then trace their callers. Done means the sender reference is passed through consistently and the updated callback signature is supported without breaking existing behavior; run the repository's relevant tests if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100