rfc7230 violation
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
I found it when tried to use it as client with proxy.
When connecting to proxy websocket-sharp sends CONNECT request to proxy with request-target's authority component not equal to Host header (if port is 80), while RFC 7230, section 5.4: Host states:
If the target URI includes an authority component, then a
client MUST send a field-value for Host that is identical to that
authority component, excluding any userinfo subcomponent and its "@"
delimiter (Section 2.7.1).
So, to match rfc7230 definition port == 80 check in this line should be removed
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in HttpRequest.cs at the linked line around 125 and inspect how the proxy CONNECT request-target and Host header are assembled. Confirm the RFC 7230 requirement for port 80, then verify that the generated CONNECT request uses matching authority values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100