sta / sta/websocket-sharp

Proxy issue

Open
#422 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
6.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

I was having an issue connecting on some proxy servers and I think I've fixed it myself I had to change this line of code.

public bool HasConnectionClose {
get {
return Headers.Contains ("Connection", "close") || Headers.Contains("Proxy-Connection", "close");
}
}

Adding Proxy-Connection check in the header.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the HasConnectionClose property shown in the issue and inspect how the Connection header is checked. Verify proxy behavior with a focused test or reproducible proxy scenario; done means close detection also handles a Proxy-Connection header containing close.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.