a WebBehaviour OnOpen called but OnClosed isn't
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
I've seen a cases where OnClose on a WebBehaviour hasn't been called. This is due to the session _id not yet having been assigned and therefore the close event isn't called. The issue I tracked down to to the WebSocket open function where a startReceiving call can process a frameclose packet, even before the OnOpen event is called.
startReceiving();
try {
OnOpen.Emit (this, EventArgs.Empty);
One fix for this could be to call startReceiving after the OnOpen event. Although I'm not sure if there are any negative consequences of this.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the WebSocket open function around startReceiving() and OnOpen.Emit, and trace how a frameclose packet is handled before the session _id is assigned. Reproduce the early-close sequence and confirm that the resulting behavior calls both OnOpen and OnClosed in the appropriate order.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100