sta / sta/websocket-sharp

Pong not receiving

Open
#32 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
6.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

I have not looked into this too much more yet, but I did a quick test where the pong is not being received from wss://echo.websocket.org on the latest master code.

We have used websocket-sharp before and it was working fine when WebSocketState was still WsState (so more than 6 months ago). So switching back to the older code does have pong being received.

Any notes or suggestions on changes that may have occurred on the implementation would be great. We are listening for Opcode.PONG in OnMessage.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the missing pong against wss://echo.websocket.org on the latest master, then compare the current implementation with the older code that received pong frames. Start from the OnMessage listener for Opcode.PONG; done means pong messages are received again on the current implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.