sta / sta/websocket-sharp

SendAsync callback completed boolean true, but no data logged at Server

Open
#305 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
6.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

WebsocketSharp Version: 1.0.2.30210

I'm using the following code in my CLIENT app:

ws.SendAsync("Send this to Server", new Action<bool>((completed) =>
{
  if (completed)
  {
    logSendSuccess();
  }
  else {
    logSendFail();
  }
}));

I have never found that completed == false in my (and my clients) use of websocket-sharp (i.e. logSendFail() is never called).

completed always seems to be true, even times when my SERVER did not receive the message (by inspecting the missing entries of the server logs). I would expect completed to ONLY be true on a SUCCESSFUL completion and false otherwise.

Is this a known issue ? Or has it been fixed in newer versions (I noticed there is a 1.0.3-rc11 on NuGet) ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the SendAsync implementation and its Action callback contract, then compare callback results with the reported server-log evidence. No test or source file is named in the issue; done means the callback behavior is established and the reported mismatch is resolved or documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.