Invalid ReadyState of a client
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
Why is the ReadySate of a client which has never attempted to connect, WebSocketSharp.WebSocketState.Connecting?
I would expect the state to be WebSocketSharp.WebSocketState.Closed instead.
The culprit seems to be here: https://github.com/sta/websocket-sharp/blob/master/websocket-sharp/WebSocket.cs#L1134
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open websocket-sharp/WebSocket.cs around line 1134 and inspect how the initial client state is assigned before any connection attempt. Reproduce the state of a never-connected client and compare it with the expected Closed state. Done means the initial ReadyState reports Closed without changing states for clients that attempt to connect.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 42/100