sta / sta/websocket-sharp

Ping method blocks

Open
#273 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
6.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

Hi - most of the websocket read/write api's are asynchronous. However, Ping appears to be an exception. Is it possible to create an overload of Ping which does not block, waiting for the Pong?

I would need some way to know the pong was received. Maybe add an option to "emitOnPong"?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Ping method and reviewing how the websocket read/write APIs handle asynchronous completion. Determine how a non-blocking Ping could report receipt of Pong, including whether an overload or an emitOnPong option fits the existing API. Done means the proposed behavior is specified and covered by tests for sending Ping and observing Pong.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
networking
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.