sta / sta/websocket-sharp

Why WebSocket implements IDisposable explicitly?

Open
#171 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
6.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

Why?

It's not that rare to find the case to want to call Dispose manually instead of shielding it with using.

For instance, If you are encapsulating WebSocket in another class you'll probably implement IDisposable on your class calling WebSocket's Dispose on your Dispose.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced WebSocket.cs lines 2638-2651 and inspect how WebSocket implements IDisposable. The issue does not specify a concrete change, so determine whether the intended outcome is an API change or an explanation before defining what completion means.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.