Null reference exception in Shell when channel is unexpectedly closed
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 4.4k
- Forks
- 993
- Avg merge
- 9d 21h
- Merged PRs (30d)
- 1
Description
If the underlying network channel is unexpectedly closed, then in Channel_Closed the _channel member is set to null. This can result in a NullReferenceException when the background read thread attempts to send any new data.
Also _dataReaderTaskCompleted has a similar problem.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Channel_Closed, the _channel member, and _dataReaderTaskCompleted in the SSH.NET source. Trace how the background read thread handles a closed channel and how completion is checked. Done means an unexpected channel close no longer causes a NullReferenceException when new data arrives or when the reader task completes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100