empty passphrases not allowed?
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 4.4k
- Forks
- 993
- Avg merge
- 9d 21h
- Merged PRs (30d)
- 1
Description
getting an error with empty passphrases.
making difficult to use lib in our CD environment. is it correct that empty passphrases are not allowed?
looking at line 152 of privatekeyfile.cs:
if (!string.IsNullOrEmpty(cipherName) && !string.IsNullOrEmpty(salt))
{
if (string.IsNullOrEmpty(passPhrase))
throw new SshPassPhraseNullOrEmptyException("Private key is encrypted but passphrase is empty.");
If this is intended behavior I suppose this can be closed, seems strange to prevent behavior allowed by ssh.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Renci.SshNet/PrivateKeyFile.cs at the referenced line and trace how encrypted private keys handle an empty passphrase. Compare that behavior with the SSH behavior described in the issue and determine whether empty passphrases should be accepted; done means the intended behavior is established and the issue's reported CD use case is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100