ScpClient: Uploading and Downloading events should provide absolute local and remote path
Open
@drieseng is already working on this.
Since Aug 26, 2017.
enhancement
- Dominant language
- C#
- Stars
- 4.4k
- Forks
- 993
- Avg merge
- 9d 21h
- Merged PRs (30d)
- 1
Description
Problem
Right now, the ScpDownloadEventArgs and ScpUploadEventArgs classes only have a single Filename property that contains the only file name of the local or remote file that this being downloaded or download.
For the Download overloads, ScpDownloadEventArgs.Filename always contains the file name of the remote file that is being downloaded.
For the Upload overloads, there's little consistency in the value of ScpUploadEventArgs.Filename:
- For
Upload(FileInfo fileInfo, string path), its value is the file name of the local file. - For
Upload(Stream source, string path)andUpload(DirectoryInfo directoryInfo, string path), its value is the file name of the remote file (which is the only path available).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.